Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.14.4] Localization issue #19

Closed
Aizistral opened this issue Sep 23, 2019 · 1 comment
Closed

[1.14.4] Localization issue #19

Aizistral opened this issue Sep 23, 2019 · 1 comment
Assignees
Labels
type: bug Something isn't working

Comments

@Aizistral
Copy link
Contributor

Aizistral commented Sep 23, 2019

Versions:

  • Curios: FORGE-1.14.4-1.0.0.1
  • Forge: 28.1.14

Observed Behavior:

So, there is one small problem that I've found out while working on Russian localization for my mod, when I decided to make one for Curios, too. It lies in EventClientHandler's onTooltip method, in this line:

tooltip.add(
         new TranslationTextComponent("curios.modifiers", identifier).applyTextStyle(
         TextFormatting.GOLD));

The way it is implemented does not allow to localize the identifier, and so any trinket type will be displayed as identifier defined upon type registration.

Expected Behavior:

It's generally up to you how to change this implementation, but I would offer creating separate lozalization keys for "When on %s:" tooltip, since there might be required declensions and other language-specific stuff.

@Aizistral Aizistral added the type: bug Something isn't working label Sep 23, 2019
@TheIllusiveC4
Copy link
Owner

You raise a good point. I'll change it to require specific keys in the form of curios.modifiers.<identifier>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants