You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So, there is one small problem that I've found out while working on Russian localization for my mod, when I decided to make one for Curios, too. It lies in EventClientHandler's onTooltip method, in this line:
tooltip.add(
new TranslationTextComponent("curios.modifiers", identifier).applyTextStyle(
TextFormatting.GOLD));
The way it is implemented does not allow to localize the identifier, and so any trinket type will be displayed as identifier defined upon type registration.
Expected Behavior:
It's generally up to you how to change this implementation, but I would offer creating separate lozalization keys for "When on %s:" tooltip, since there might be required declensions and other language-specific stuff.
The text was updated successfully, but these errors were encountered:
Versions:
Observed Behavior:
So, there is one small problem that I've found out while working on Russian localization for my mod, when I decided to make one for Curios, too. It lies in EventClientHandler's onTooltip method, in this line:
The way it is implemented does not allow to localize the identifier, and so any trinket type will be displayed as identifier defined upon type registration.
Expected Behavior:
It's generally up to you how to change this implementation, but I would offer creating separate lozalization keys for "When on %s:" tooltip, since there might be required declensions and other language-specific stuff.
The text was updated successfully, but these errors were encountered: