Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curios in combination with Curios Armor Stands performance issue. #251

Closed
NoxyNixie opened this issue Jul 25, 2022 · 1 comment
Closed
Assignees
Labels
type: bug Something isn't working

Comments

@NoxyNixie
Copy link

NoxyNixie commented Jul 25, 2022

Versions:

Observed Behavior:

I've noticed curious being rather hungry in performance on some entities where I wasn't expecting curios to do much.

Below is a profile view of entities being ticked in one minute. As you can see Curios event handler is taking 1.36% on an armor stand in comparison the second worst event handler is only 0.05%.
image

On our dedicated server with a large world and various dungeons that have generated in armor stands the impact of this is even worse that in the above picture (which is single player). It also has me somewhat worried about potentially pointless network traffic due to armor stands and curios since the trace contains packet related things.

When checking for how many armor stands there are forge entity list only shows 10 in the same exact location the above profile was done so it is not an excessive amount.

Removing only Curious armor stands from the mod pack does resolve this issue.

Expected Behavior:

Curios to not do any ticking with armor stands. If somehow this is still needed an option to disable this would be neat.

I'm not sure if this falls on Curious itself to resolve or the Curios Armor Stand mod.

(Cross posted here too: ochotonida/curious-armor-stands#7)

@TheIllusiveC4
Copy link
Owner

Curios only provides a player implementation currently, so the performance impacts of the armor stand implementation would need to be addressed by Curious Armor Stands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants