Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect sampling from masked regions #7

Closed
fercer opened this issue May 10, 2024 · 1 comment
Closed

Incorrect sampling from masked regions #7

fercer opened this issue May 10, 2024 · 1 comment

Comments

@fercer
Copy link
Collaborator

fercer commented May 10, 2024

The last update retrieves the valid sampling positions from masked regions incorrectly.

This is mainly due to mask coordinates not being offsetted by the current chunk location.

There is also an error when computing the coverage of patches which coordinates are lower than the lowest mask coordinate.

@fercer fercer mentioned this issue May 10, 2024
@fercer
Copy link
Collaborator Author

fercer commented May 10, 2024

Solved with #8

@fercer fercer closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant