Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar #25

Closed
TheLastGimbus opened this issue Dec 5, 2020 · 2 comments · Fixed by #67
Closed

Progress bar #25

TheLastGimbus opened this issue Dec 5, 2020 · 2 comments · Fixed by #67
Assignees
Labels
enhancement New feature or request

Comments

@TheLastGimbus
Copy link
Owner

TheLastGimbus commented Dec 5, 2020

So right now, the script just prints every file while fixing it's metadata, and when something bad happens, the last printed path is the photo that caused problem

My idea: wrap fix_metadata in a try-catch all, then inside catch print the photo path and then re-throw previously caught exception (because dummly catching and ignoring all exceptions would be bad)

Also adding progress bars to removing duplicates and coping would be nice

@TheLastGimbus TheLastGimbus added the enhancement New feature or request label Dec 5, 2020
@TheLastGimbus TheLastGimbus self-assigned this Dec 5, 2020
@jmigual
Copy link
Contributor

jmigual commented Jan 25, 2021

If you want to add a progress bar you may want to take a look at https://github.com/tqdm/tqdm. Basically, you can wrap for loops with tqdm() and it shows a progress bar.

@conradstorz
Copy link
Contributor

I'll be happy to add the try/except wrapper you described if you like what I have proposed for the use of tqdm in my pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants