No folders named like the README instructions? #30
Comments
Hm, you can probably do any of this, it should work anyway Can you describe how you used your phots? Did you just use the app, or did you upload them by hand from some other camera, or what? Also, |
|
Hi, |
|
Jezus fucking Christ, Google... |
|
Actually, now that you mention it, I believe that some time in the past, I did upload my entire photo library to Google Photos library (some time between 2016-2018, since I thought it'd be nice to have my entire library in the cloud). So everything before that time was uploaded probably through the website or Google Drive (I don't remember at this point, honestly), and then almost everything after that was through the Google Photos app. Directory tree that I have: Here's the ls: Removed album names, for privacy. But all the photos have that general structure, with custom albums, and then the EDIT: Just realized the folder structure might be of importance so this is |
|
I just extractes all my takeout chunks into one folder. |
|
Yup Google now names folders "Photos from YYYY". Tool says: Wrong folder name: Photos:fro 12:00:00 |
+1 also having this issue with that exact error |
|
Hi, does it work if I manually rename the folders from "Photos from 2016" to "2016-01-01" ? |
|
Huh... that's a very interesting question Generally, this script uses folder name as a last chance when picture has no exif data nor .json was found. So if that happens, you will have photos with that date - you will have them listed in final stats file 👍 Tell me how it went if you do that |
|
Hey guys! What is the status on this issue then? |
|
Idk honestly - but it will probably quickly be solved - after Christmas 🎄 |
|
Hey @ everyone! Looks like @bitsondatadev almosted finished #36 - now, I need to test this before merging and making new version Could you pull from his fork: https://github.com/bitsondatadev/GooglePhotosTakeoutHelper/tree/handle-albums-with-hash - and test if your "new takeouts" work with it? I would be really grateful! |
|
Also looking forward for support of the new structure. |
|
@popy2k14 if you are looking forward, help us in testing it 😉 Branch above should fully work now - just checkout and test if it works for you |
|
I tested it under windows. Correct "Created" date in windows is not set, please look at my tool how I managed that. |
|
Test under Windows 10 Pro 20H2 build with newest python 3.9.1 from MS store. any hints? thx |
You just used official version of script that is on pypi To use our WIP code, you need to: git clone https://github.com/bitsondatadev/GooglePhotosTakeoutHelper/ takeout-test
cd takeout-test
git checkout --track origin/handle-albums-with-hash
python3 google_photos_takeout_helper/__main__.py -i [INPUT] -o [OUTPUT] |
|
I was using the new branch from the above link. Sadly, also with your approach, it doesnt work:
@bitsondatadev Any hints? Seems time converting fails. thx |
How the hell does 🤷 |
|
Thats the question :-) |
|
I have found the issue.
to
And it works. Seems there was the two arguments file & timestamp missing for the "setctime" function. |
|
Oh, I had to be really asleep when I was writing this xD fixed, now try it Ps. you need to git pull origin handle-albums-with-hash |
|
Its running now, but i got very often the message that no json was found. Output of script:
After a look at the files if found this:
There is an (1) at another position in the filename. Will this not be taken into account? |
|
To overcome this i have done the following workaround on my folder with WSL:
This removes the (1) and running the script afterwards sets the exif data from json correctly. Would be nice if this would be confirmed and integrated into the script. |
|
It's okay, we have plans for better "json finding" - most important - does it generally work? |
|
Yeah I think it's necessary to a better way to find the json file. Generally: it works now. |
🎉
|
Hi, thought I'd give this a shot, however I noticed that after using takeout, I don't have any folders in the YYYY-MM-DD format or anything like that. Each takeout folder is mostly comprised of albums, with the closest being Photos from YYYY. I'm not sure if this is because it originally synced with Google Drive, or what.
And also, might be unrelated, but if using macOS, can I just copy-merge the folders so I have
./Takeout/Google\ Photos/<everything copy-merged here>or should it each Takeout folder just be put into a folder (no merge) like./folder/<Takeout [1-N]>The text was updated successfully, but these errors were encountered: