Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in logic to update expiration times on subsequent tracks when no one is listening #47

Closed
TheLoombot opened this issue Oct 29, 2018 · 1 comment
Assignees
Projects

Comments

@TheLoombot
Copy link
Owner

There's a bug in the logic I wrote to update expiration times on subsequent tracks when you skip the first track.

Easiest way to reproduce:

  1. Add two 1-minute tracks to the playlist
  2. Close the app (and make sure no one else is using it)
  3. Come back after 3 minutes
  4. Expected behavior: When you return to the app, both tracks should have expired and been removed
  5. Actual behavior: The first track is expired and removed, but then the subsequent tracks have their expiration times updated and start playing immediately

Basically, the problem is in the playlist service's recalcTimes method. When we do Updating expiration time on new track 0 ... we need to take the original expiration time into account better... if the track's original expiration time has already passed, it should be removed, not updated!

@TheLoombot TheLoombot self-assigned this Oct 29, 2018
@TheLoombot TheLoombot added this to High priority in Main Board Feb 9, 2019
TheLoombot added a commit that referenced this issue Jun 9, 2020
@TheLoombot
Copy link
Owner Author

Pretty straightforward fix actually... just ignore expired tracks and don't bother updating their expiration times! See attached commit 9150a8e

Main Board automation moved this from High priority to Closed Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Main Board
  
Closed
Development

No branches or pull requests

2 participants