Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ploting the result #17

Closed
zyzhang1130 opened this issue Feb 3, 2020 · 2 comments
Closed

ploting the result #17

zyzhang1130 opened this issue Feb 3, 2020 · 2 comments

Comments

@zyzhang1130
Copy link

Hi,
I have another question. After I run the main.py of rainbow there is no plot coming out, but clearly in the test.py there is a _plot_line command which is supposed to be called if the main.py is executed. After checking, it is discovered that in main.py line149:
avg_reward, avg_Q = test(env, mem_steps, args, dqn, val_mem, evaluate_only=True)
and line179:
if num_steps % args.evaluation_interval == 0:
(hence line182 avg_reward, avg_Q = test(env, num_steps, args, dqn, val_mem) )

were never executed, which means that:
if args.evaluate_only: #line147
and
if num_steps >= args.learn_start: #line172

were never satisfied.

I didn't modify any part of the code except changing --max-num-steps (line 34) to 1000 for checking result promptly.

Do you have any clue what is the cause?

Thank you.

@beduffy
Copy link
Contributor

beduffy commented Feb 11, 2020

'--evaluation-interval', type=int, default=1e5
evaluation-interval is 1e5 which is 100,000, you probably just didn't wait this long. You should set that argument number lower (e.g. 2000) and then you will execute test sooner due to line 179 and then this will plot the results and save the model if the average reward is best.

@zyzhang1130
Copy link
Author

zyzhang1130 commented Feb 12, 2020

Hi, it worked. Thank you for the advice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants