Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modpacks #4

Closed
5 of 6 tasks
TheMulhima opened this issue Apr 30, 2023 · 3 comments · Fixed by #73
Closed
5 of 6 tasks

Modpacks #4

TheMulhima opened this issue Apr 30, 2023 · 3 comments · Fixed by #73
Labels
enhancement New feature or request
Milestone

Comments

@TheMulhima
Copy link
Owner

TheMulhima commented Apr 30, 2023

TODO

  • Create UI for managing packs
  • Add code for adding/removing packs
  • Add UI for editing packs
  • Add code for adding additional assets
  • Add code for sharing pack via sharing code
  • Add code for manual sharing
@TheMulhima TheMulhima added the enhancement New feature or request label Apr 30, 2023
@TheMulhima TheMulhima added this to the v2.1.0.0 milestone May 25, 2023
@TheMulhima TheMulhima removed this from the v2.1.0.0 milestone Jun 8, 2023
@TheMulhima
Copy link
Owner Author

Plan for implementation

Creating/Editing the pack

When create pack is pressed ask for pack name and description. Then copy the Mods folder and paste it in the Managed folder and rename it to PackName. Then get the mods in PackName and add it to packMods.json. If the user wants to edit the pack, it will edit the list in packMods.json

Loading the pack

To load the pack, Scarab will replace the current mods folder with the Pack folder and then do the required steps to make it match with packMods.json. To make this operation faster in the future, if the mods were edited, recopy them into the pack folder

Sharing the pack

To share the pack, there will be a button in the pack list that when pressed will use the packMods.json to generate a JSON compatible with the hpackage-schema. By default, no additional assets will be added so it will prompt to add them if required. Any additional assets will be stored as text if < 1MB, or using catbox if < 200MB. Then the JSON will be uploaded to pastebin and 8 digit identifier of the pastebin will be the "sharing code" This code can be used to import packs

Manual Sharing

Since catbox and pastebin don't have usability garuntees (because they are free) there will be an option for manual sharing which will just just zip the pack folder and ask where to save it. Then user can manually share it and the other user can press import pack and install it

UI

Initial UI design idea: https://www.figma.com/community/file/1251576832566083349

Basic UI Requirements are:

  • Add a new tab for mod packs. The main page will have the list of packs and buttons for create pack and import pack at the bottom
  • Add a window for create pack that has boxes for name and description
  • Add a window for edit pack which allows you to add/remove mods and add additional assets

@TheMulhima TheMulhima pinned this issue Jun 17, 2023
@TheMulhima TheMulhima added this to the v2.2.0.0 milestone Jun 30, 2023
@Acu1000
Copy link
Contributor

Acu1000 commented Jul 30, 2023

I suppose the mods that are in modlinks and aren't prevented from auto-updaing could be stored as simply a list (probably .json) of names rather than copying the whole thing

@TheMulhima
Copy link
Owner Author

Yea that was thought of initially but what then came up is it shouldn't be a task to change a modpack. Copying the folder locally regardless if it wants to be fixed version or not would greatly improve pack changing speed

@TheMulhima TheMulhima linked a pull request Sep 8, 2023 that will close this issue
@TheMulhima TheMulhima unpinned this issue Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants