Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling React Applications(React): clarifications regarding Tailwind CSS as a styling option #27867

Closed
3 tasks done
Siriuszx opened this issue Apr 26, 2024 · 1 comment · Fixed by #27874
Closed
3 tasks done
Assignees

Comments

@Siriuszx
Copy link
Contributor

Siriuszx commented Apr 26, 2024

Checks

Describe your suggestion

The problem

Hi there! In the lesson it's clearly stated that when it comes to the implementation of our component styles throughout the course we should stick to Vanilla CSS or CSS-in-JS. However, when you scroll up a little bit, you see Tailwind CSS categorized as Vanilla CSS option. So I asked guys in the chat back then and got the response in the spirit of "people doing this course should stick to writing their own CSS and stay away from frameworks as regular CSS is something that all of those frameworks are built upon" (1), which I completely agree with.

So we've got the general consensus that students should avoid using CSS frameworks (and to "implement your own component's styling from scratch" (2)) at least until the end of the TOP and the lesson telling people to stick to Vanilla CSS and listing Tailwind CSS as a valid Vanilla CSS option.

Which basically contradicts the general advice because:

  • Tailwind isn't regular CSS and is a framework which violates (1)
  • Tailwind provides a whole system which dictates the overall style of the app which violates (2)

The solution

I would like to use more specific wording instead of "Vanila CSS" since it's rather vague (and Tailwind could be considered as Vanilla CSS in that context) and remove Tailwind CSS documentation reference from "Additional resources" section but leave it as "Vanilla CSS" option in the list to avoid confusion and funnel people into writing regular CSS.

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/node-path-react-new-styling-react-applications

Discord Name

SiriusMain#6886

Additional information

@wise-king-sullyman
Copy link
Member

Sounds good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants