Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EyeDropper API when it lands in Electron #229

Closed
patrickhlauke opened this issue Oct 19, 2021 · 9 comments
Closed

Use EyeDropper API when it lands in Electron #229

patrickhlauke opened this issue Oct 19, 2021 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@patrickhlauke
Copy link
Collaborator

@ferllings ferllings added the enhancement New feature or request label Oct 20, 2021
@ferllings ferllings self-assigned this Oct 20, 2021
@ferllings
Copy link
Member

That works so great !!
I need to do some tests on color spaces, but this is already a huge step.

Thanks Patrick

@ferllings
Copy link
Member

Looks like electron 16 alpha, uses Chrome 96. I'll do some tests on it.

@patrickhlauke
Copy link
Collaborator Author

Perfect :)

@patrickhlauke
Copy link
Collaborator Author

@ferllings
Copy link
Member

I'm currently working on it, but I have some difficulties to migrate from Electron v12 to v16.
But my initial test with the EyeDropper api was successfull.
The only issue with it is that it is not movable using the keyboard (yet?)

@patrickhlauke
Copy link
Collaborator Author

patrickhlauke commented Nov 25, 2021

The only issue with it is that it is not movable using the keyboard (yet?)

possibly worth filing a bug/request for chrome (and then any other browser that implements it)

edit: there's this already https://bugs.chromium.org/p/chromium/issues/detail?id=1141519

@ferllings
Copy link
Member

I've also left a comment here:
WICG/eyedropper-api#22

@patrickhlauke
Copy link
Collaborator Author

Yay!

@ferllings
Copy link
Member

Big disappointment, there is a bug in Electron/Window 10:
electron/electron#27980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants