We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug Very rarely, there are certain colour combinations that cause a JS error and don't update the contrast ratio calculation
Desktop (please complete the following information):
To Reproduce Steps to reproduce the behavior:
#000
#FFF
#F56E00
Expected behavior Contrast ratio to be updated
Screenshots Animated gif showing how pasting #F56E00 into foreground dosn't update the calculated contrast
Additional context Following error is shown in devtools console:
C:\Program Files\CCA\Colour Contrast Analyser\resources\app.asar\src\views\js\main.js:321 Uncaught ReferenceError: t is not defined at applyContrastRatio (C:\Program Files\CCA\Colour Contrast Analyser\resources\app.asar\src\views\js\main.js:321:56) at EventEmitter.<anonymous> (C:\Program Files\CCA\Colour Contrast Analyser\resources\app.asar\src\views\js\main.js:60:5) at EventEmitter.emit (node:events:526:28) at Object.onMessage (node:electron/js2c/renderer_init:69:746) applyContrastRatio @ C:\Program Files\CCA\Colour Contrast Analyser\resources\app.asar\src\views\js\main.js:321 (anonymous) @ C:\Program Files\CCA\Colour Contrast Analyser\resources\app.asar\src\views\js\main.js:60 emit @ node:events:526 onMessage @ node:electron/js2c/renderer_init:69
The text was updated successfully, but these errors were encountered:
Hi Pat, nice to see you around.
This issue has been fixed in 0e9a5cb
Sorry, something went wrong.
@ferllings any chance that could be pushed to a new release then?
Yes, I was waiting for few things, but I postponed for too long. I'll just need to do #284 before releasing
thanks for the release today @ferllings ... confirming that this is now fixed :)
No branches or pull requests
Describe the bug
Very rarely, there are certain colour combinations that cause a JS error and don't update the contrast ratio calculation
Desktop (please complete the following information):
To Reproduce
Steps to reproduce the behavior:
#000
against#FFF
with a ratio of 21:1#F56E00
into the foreground colour fieldExpected behavior
Contrast ratio to be updated
Screenshots
Animated gif showing how pasting
#F56E00
into foreground dosn't update the calculated contrastAdditional context
Following error is shown in devtools console:
The text was updated successfully, but these errors were encountered: