Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aViewer compatibility with Windows 10 / releasing updated versions #3

Closed
patrickhlauke opened this issue Jul 13, 2015 · 9 comments
Closed

Comments

@patrickhlauke
Copy link
Contributor

Just a placeholder issue, as Windows 10 final isn't out yet...but worth flagging up that in one of the recent Insider Preview builds (10162) aViewer does not seem to work at all - the application starts, I can register the .dll, but nothing is displayed. In certain situations, I can get the yellow "focus only" rectangle to appear, but even this is inconsistent.

@stevefaulkner stevefaulkner assigned ghost Jul 13, 2015
@ghost
Copy link

ghost commented Jul 29, 2015

Which browser are you using?
Edge browser: Each element doesn't return IAccessible.
Firefox: The QueryService function for "ISIMPLEDOMNODE" fails. I don't know the cause.
After Windows 10 is released, I will examine them.

@patrickhlauke
Copy link
Contributor Author

Just revisiting this with release version of Windows 10. The aViewer version we currently distribute on the TPG site http://www.paciellogroup.com/resources/aviewer/ crashes consistently as soon as you switch from aViewer (with "highlight focus" and the "show rectangle" options on) to IE11.

The builds here on GitHub do work nicely though. Is there any reason why we're not pointing the public to those builds, rather than the (now outdated, I'm guessing) 2014 version? Could we do a proper "release" and point to it, like we do for WAT? http://www.paciellogroup.com/resources/wat/

@patrickhlauke patrickhlauke changed the title aViewer compatibility with Windows 10 aViewer compatibility with Windows 10 / releasing updated versions Aug 3, 2015
@stevefaulkner
Copy link
Contributor

@patrickhlauke sounds like something we should do pronto looping in @matatk as he is lord of the releases

@matatk
Copy link

matatk commented Aug 4, 2015

That sounds like an ominous title :-). I'm not sure where we are with this aViewer; seems like it is behind the times, as @patrickhlauke says. The long-term plan would be to:

  • Get all the code that makes up CCA, aViewer and WAT into their repos (currently we depend on some binary parts), so that
  • we can build a complete release entirely from the source on GitHub (no binaries, on which we currently depend) at any time, and
  • we could link the WAT repo to the CCA and aViewer repos, so that when WAT is built, a certain CCA/aViewer release is built (using git submodules would be good for this, as it would allow us to decide which CCA/aViewer revision to include in any given WAT revision, so we can still manage releases).

Steve found what appears to be a suitable IDE called Lazarus which we are hoping we could use. Perhaps we could enlist @jun325's help to

  • see if lazarus is a viable solution, and, if so,
  • get all the code on GitHub so we can start to link things up, as above.

If we could ask @jun325 to get all the source up here and to check the IDE will work for us, then I could look at linking the repos together and making a build process that will build and include them all when WAT is built. How does that sound?

@stevefaulkner
Copy link
Contributor

thanks @matatk sounds like a plan, what can we do in th short term to make the windows 10 compatible version available?

@patrickhlauke
Copy link
Contributor Author

can we just package up the existing .exe files that are here right now as a release, and worry about the most correct way to package everything up for the next release? that way, we can get the quick low-hanging fruit of just pointing the TPG site to the github release in the first instance, so in future we won't have to bother updating the site and automagically always point to the freshest version? @matatk

@matatk
Copy link

matatk commented Aug 4, 2015

Those two approaches are not incompatible -- it would be good to get a release out ASAP, yes. I think we really need to do the full approach ASAP after that, though, or it'll be a black hole for maintenance time :-).

IIRC there's not much to do to package up an aViewer 'release' as there's no installer, so this could be done quite quickly. I can look into it later today perhaps... I've made a new issue to track this: #5

@matatk
Copy link

matatk commented Aug 4, 2015

Also, quick note for future reference: when the above stuff with code has been completed, git should no longer be used to store any .exe or .dll files (as it will not be needed; we will build them). Only the releases will need to contain such files.

@patrickhlauke
Copy link
Contributor Author

Closing as the immediate issue at the time (Win 10 compat and making a quick release) has been resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants