Keep viewport when switching files

[lars-vc]

What issue are you having that you need harpoon to solve?
I would like to keep the viewport after switching files, currently the line is always centered on the screen.
Keeping the viewport would only be necessary in the same session (after nvim reboot this is not required)

Why doesn't the current config help?
No options are provided for this

What proposed api changes are you suggesting?
Vim already has some options to keep the viewport with winsaveview() and winrestview(view), these could be used to save the viewport.

[ThePrimeagen]

you want the same position the viewport was in before you left the file? is that what you are asking?

[lars-vc]

Yes, when using harpoon I like to switch between files quickly, to for instance just take a glance at some code and hop back. When this centers the line every time, this gets disorienting.
Example: I am working here

Then quickly check another file with harpoon keybind and go back with harpoon keybind and now the line is centered

[lpanebr]

I also would like that.

[ThePrimeagen]

Okay, it seems like an okay feature. I don't really use it nor notices, so if someone would like to take a swing at saving the additional information required in the list items, context and using that on select I'd be just fine merging it in

[lars-vc]

Okay, I tried some stuff but got a lil confused, so here

harpoon/lua/harpoon/config.lua

Line 194 in 9031087

)

you save where you are at in the file when leaving a buffer correct? But when testing, it seems this code is never triggered (the logger line right before doesn't show up).
So is this not working? Or am I doing something wrong.

[lars-vc]

This wiki is related to the problem viewport problem @lpanebr . Might just use this for consistency everywhere
https://vim.fandom.com/wiki/Avoid_scrolling_when_switch_buffers

[lpanebr]

@lars-vc Thank you! This is just AWESOME and works like magic! ❤🎉

This wiki is related to the problem viewport problem @lpanebr . Might just use this for consistency everywhere https://vim.fandom.com/wiki/Avoid_scrolling_when_switch_buffers

[ThePrimeagen]

I am back, I'll review this today and merge/give feedback