-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This code seems not to work with rescript 11.beta.2 and 3 #15
Comments
Yeah, this seems to be an issue with the core package. Upgrading 'rescript' causes this issue: diff --git a/package.json b/package.json
index fdfeb0b..7855cf1 100644
--- a/package.json
+++ b/package.json
@@ -29,7 +29,7 @@
"@dusty-phillips/rescript-zora": "^3.0.0",
"onchange": "^7.1.0",
"pta": "^1.0.0",
- "rescript": "^10.0.1",
+ "rescript": "^11.0.0-beta.3",
"zora": "^5.0.0"
}
} I didn't see anything immediately obvious in release logs since v10. |
That seems to be the problem |
Bingo... rescript-lang/rescript-compiler#6285 I'll try get the needed files added here :) |
Oh good find! We could perhaps just add types to this project, but that would then make it incompatible with ReScript 10. I'll ask. |
Yeah, maybe a major version bump, and it requires rescript 11 or higher? |
Bundling my own types is the recommended solution. And yes it will need a new major. |
@JasoonS As a temp solution you can use the version from my PR:
|
Cool, thanks - beat me to it @DZakh 💪 |
I get the following error after newly adding this package to a new project:
I'll clone locally and investigate a bit - seems strange - but I also don't know what
Node_module
is.The text was updated successfully, but these errors were encountered: