This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Translation improvements #52

Merged

Kirottu merged 3 commits into TheTerminalCafe:develop from UltimateNyn:translate-improvements

Oct 28, 2022

Collaborator

UltimateNyn commented Oct 7, 2022

This includes 3 changes:

When translating the Embed will now use the full language name instead of the language code (changing de -> English to German -> English)
The translate_text just returns a tuple with 2 Strings and takes lang as String. Now it's more documented and it's clear that it takes the target language as argument
When translating into Beemovie the source language is now Human

UltimateNyn added 3 commits

October 7, 2022 20:41


          translate: use full language name instead of code

968f012


          translate: improve variable names + add comment

af426c8


          translation: use Human as source lang for Beemovie

Kirottu approved these changes

View reviewed changes

Contributor

Kirottu left a comment

Looks fine.

Kirottu merged commit 0e89d80 into TheTerminalCafe:develop

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.