Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate unmarshallers always if a submessage has a fieldmask #18

Closed
ysmilda opened this issue Nov 16, 2022 · 0 comments · Fixed by #19
Closed

Generate unmarshallers always if a submessage has a fieldmask #18

ysmilda opened this issue Nov 16, 2022 · 0 comments · Fixed by #19
Assignees
Labels
needs/triage We still need to triage this
Milestone

Comments

@ysmilda
Copy link
Contributor

ysmilda commented Nov 16, 2022

With the migration to proto v2 from gogoproto we're running into issues with how we historically rendered field masks. We used the {"field_mask":["field1", "field2"]} while they are meant to be just {"field_mask":"field1,field2"}. To not break anything when migrating we need to make sure that both formats are accepted by the unmarshallers.

For marshallers/unmarshallers currently generated by protoc-gen-go-json this is already the case, but for the other messages that use the standard marshallers this doesn't happen.

The proposal is to have protoc-gen-go-json generate all marshallers/unmarshallers for messages with fieldmasks.

@ysmilda ysmilda added this to the Q4 2022 milestone Nov 16, 2022
@ysmilda ysmilda self-assigned this Nov 16, 2022
@github-actions github-actions bot added the needs/triage We still need to triage this label Nov 16, 2022
@ysmilda ysmilda linked a pull request Nov 16, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/triage We still need to triage this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant