Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow legacy fieldmask marshaling #20

Closed
adriansmares opened this issue Dec 13, 2022 · 0 comments · Fixed by #21
Closed

Allow legacy fieldmask marshaling #20

adriansmares opened this issue Dec 13, 2022 · 0 comments · Fixed by #21
Assignees
Milestone

Comments

@adriansmares
Copy link
Contributor

References https://github.com/TheThingsIndustries/lorawan-stack/pull/3445

We should have a global option available in the plugin that allows us to marshal google.protobuf.FieldMask as objects ({paths: ["a.b.c","d.e.f"]} instead of strings ("a.b.c,d.e.f"}.

The current state of affairs is that field mask objects can be unmarshalled both from strings, and from objects, but marshaling always goes towards strings. This breaks our API continuity for webhooks and end device template conversion.

I would like to see an option, similar to std (std=true generates standard encoding/json marshalers), which enables this legacy behavior. The most appropriate name that I can come with is legacy_fieldmask_marshaling, but feel free to suggest otherwise.

@adriansmares adriansmares added this to the Q4 2022 milestone Dec 13, 2022
@github-actions github-actions bot added the needs/triage We still need to triage this label Dec 13, 2022
@adriansmares adriansmares removed the needs/triage We still need to triage this label Dec 13, 2022
@ysmilda ysmilda linked a pull request Dec 15, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants