Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a static error HTML template for non-react handled routes #3261

Closed
kschiffer opened this issue Sep 21, 2020 · 4 comments · Fixed by #4884
Closed

Provide a static error HTML template for non-react handled routes #3261

kschiffer opened this issue Sep 21, 2020 · 4 comments · Fixed by #4884
Assignees
Labels
in progress We're working on it technical debt Not necessarily broken, but could be done better/cleaner ui/web This is related to a web interface
Milestone

Comments

@kschiffer
Copy link
Member

Summary

Following up from #233 we still need a Go HTML template that will render a generic and static error page for all errors that are not in Console or OAuth app context. See also: https://github.com/TheThingsIndustries/lorawan-stack/issues/1315#issuecomment-440656553

Why do we need this?

To display proper error pages for backend errors that are not in the scope of Console or OAuth app. E.g. https://github.com/TheThingsIndustries/lorawan-stack/issues/2268

What is already there? What do you see now?

Error page designs and error boundaries that render error views for routes that are handled by our frontend react apps.

What is missing? What do you want to see?

Templates that render static HTML/CSS for any route that is not handled by our frontend react apps.

How do you propose to implement this?

Implementing the design that we currently use for the react apps as static HTML/CSS template that renders for error responses.

How do you propose to test this?

Manual.

Can you do this yourself and submit a Pull Request?

Yes but anyone please feel free to pick up.

@kschiffer kschiffer added technical debt Not necessarily broken, but could be done better/cleaner ui/web This is related to a web interface labels Sep 21, 2020
@kschiffer kschiffer added this to the Next Up milestone Sep 21, 2020
@kschiffer kschiffer self-assigned this Sep 21, 2020
@kschiffer kschiffer changed the title Provide a static HTML template that renders errors outside of the console/oauth "namespace" Provide a static error HTML template for non-react handled routes Sep 21, 2020
@kschiffer kschiffer added the blocking Another issue or pull request is waiting for this label Apr 1, 2021
@kschiffer
Copy link
Member Author

@kschiffer kschiffer modified the milestones: Next Up, 2021 Q2 Apr 1, 2021
@kschiffer
Copy link
Member Author

@pierrephz We need a generic error page for TTS. I think you designed something like that already a while back. Can you post a recent design here? Such design should be pretty simple and contain:

  • Text for the error title
  • Text for resolution instructions
  • Some icon/visual signalling "error", with proper TTS branding
  • A link leading back to a homepage
  • A link to documentation
  • A link to support (Enterprise)

@kschiffer kschiffer modified the milestones: 2021 Q2, 2021 Q3 Jul 6, 2021
@NicolasMrad NicolasMrad modified the milestones: 2021 Q3, v3.15.1 Sep 16, 2021
@NicolasMrad
Copy link
Contributor

@kschiffer can you please advise on how this error page will look like?

@NicolasMrad NicolasMrad assigned pgalic96 and unassigned pierrephz Sep 16, 2021
@NicolasMrad NicolasMrad removed the blocking Another issue or pull request is waiting for this label Sep 16, 2021
@kschiffer
Copy link
Member Author

Yes, so we should essentially use the same design that we currently use for the react handled errors (<FullViewError />):

image

We can use a simplified footer without the buttons on the right. Also, support buttons cannot be rendered in these cases, since the config is only available in the Account app / Console.

@kschiffer kschiffer removed their assignment Sep 16, 2021
@NicolasMrad NicolasMrad modified the milestones: v3.15.1, v3.15.2 Sep 29, 2021
@pgalic96 pgalic96 added the in progress We're working on it label Oct 19, 2021
@NicolasMrad NicolasMrad modified the milestones: v3.15.2, v3.16.0 Oct 21, 2021
@pgalic96 pgalic96 added in progress We're working on it and removed in progress We're working on it labels Nov 3, 2021
@htdvisser htdvisser removed this from the v3.16.0 milestone Nov 11, 2021
@htdvisser htdvisser added this to the v3.16.1 milestone Nov 11, 2021
@htdvisser htdvisser modified the milestones: v3.16.1, v3.16.2 Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress We're working on it technical debt Not necessarily broken, but could be done better/cleaner ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants