Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic class B ping slot frequency #3686

Closed
johanstokking opened this issue Jan 20, 2021 · 3 comments · Fixed by #5745
Closed

Support dynamic class B ping slot frequency #3686

johanstokking opened this issue Jan 20, 2021 · 3 comments · Fixed by #5745
Assignees
Labels
bug Something isn't working c/network server This is related to the Network Server compat/api This could affect API compatibility in progress We're working on it
Milestone

Comments

@johanstokking
Copy link
Member

Summary

Support dynamic class B ping slot frequency.

References TheThingsNetwork/lorawan-devices#38 (comment)

Steps to Reproduce

Onboard a device with, for example, band CN470 that supports class B.

What do you see now?

There's no fixed ping slot frequency, which is a required value by NS. It is not possible to specify empty;

{
  "code": 3,
  "message": "error:pkg/networkserver:field_mask (invalid field mask)",
  "details": [
    {
      "@type": "type.googleapis.com/ttn.lorawan.v3.ErrorDetails",
      "namespace": "pkg/networkserver",
      "name": "field_mask",
      "message_format": "invalid field mask",
      "correlation_id": "2b2b2538c031439d899f8793d604b3f8",
      "cause": {
        "namespace": "pkg/ttnpb",
        "name": "missing_field",
        "message_format": "field `{field}` is missing",
        "attributes": {
          "field": "mac_settings.ping_slot_frequency.value"
        },
        "code": 2
      },
      "code": 3
    }
  ]
}

What do you want to see instead?

This should be dynamic and depending on the band.

How do you propose to implement this?

Support dynamic ping slot frequency as defined in LoRaWAN Regional Parameters based on the band; CN470, US915 and AU915 seem to be affected.

How do you propose to test this?

Test creating devices.

Can you do this yourself and submit a Pull Request?

Can review

@johanstokking johanstokking added this to the February 2021 milestone Jan 20, 2021
@johanstokking johanstokking added c/network server This is related to the Network Server compat/api This could affect API compatibility bug Something isn't working labels Jan 20, 2021
@rvolosatovs
Copy link
Contributor

Indeed, didn't see this in the spec before.
We'll have to do some refactoring to allow for this.

Also, how would this work for ABP? I suppose we will still have to force mac_settings.ping_slot_frequency.value to be set for those devices

@johanstokking
Copy link
Member Author

Also, how would this work for ABP? I suppose we will still have to force mac_settings.ping_slot_frequency.value to be set for those devices

I guess so, yes.

@htdvisser htdvisser modified the milestones: February 2021, March 2021 Mar 1, 2021
@johanstokking johanstokking modified the milestones: March 2021, Next Up Mar 1, 2021
@htdvisser htdvisser added the needs/triage We still need to triage this label Jun 3, 2021
@nejraselimovic nejraselimovic modified the milestones: Next Up, v3.14.0 Jun 7, 2021
@nejraselimovic nejraselimovic removed the needs/triage We still need to triage this label Jun 7, 2021
@adriansmares adriansmares modified the milestones: v3.14.0, v3.14.1 Jul 21, 2021
@NicolasMrad NicolasMrad modified the milestones: v3.14.1, v3.14.2 Jul 27, 2021
@NicolasMrad NicolasMrad modified the milestones: v3.14.2, v3.15.0 Aug 10, 2021
@NicolasMrad NicolasMrad removed this from the v3.15.0 milestone Sep 7, 2021
@janakj
Copy link

janakj commented Apr 4, 2022

I just came across what I believe to might be the same or similar issue. I am in US915 and when I enable class B for my device and configure beacon and ping slot frequency to 923.3 MHz manually, I get the following error:

Screen Shot 2022-04-04 at 01 42 13

Is there any way to enable class B in US915 with TTN v3.18.2?

@johanstokking johanstokking added the needs/triage We still need to triage this label Apr 4, 2022
@NicolasMrad NicolasMrad added this to the v3.19.1 milestone Apr 12, 2022
@NicolasMrad NicolasMrad removed the needs/triage We still need to triage this label Apr 12, 2022
@adriansmares adriansmares modified the milestones: v3.19.1, v3.19.2 Apr 26, 2022
@adriansmares adriansmares modified the milestones: v3.19.2, v3.20.0 May 18, 2022
@NicolasMrad NicolasMrad modified the milestones: v3.20.0, v3.20.1 Jun 7, 2022
@adriansmares adriansmares modified the milestones: v3.20.1, v3.20.2 Jun 21, 2022
@adriansmares adriansmares added the needs/hardware This needs a piece of hardware that we are currently lacking label Jul 4, 2022
@NicolasMrad NicolasMrad modified the milestones: v3.20.2, v3.21.0 Jul 12, 2022
@NicolasMrad NicolasMrad modified the milestones: v3.21.0, v3.21.1 Jul 26, 2022
@NicolasMrad NicolasMrad modified the milestones: v3.21.1, v3.21.2 Aug 29, 2022
@adriansmares adriansmares added in progress We're working on it and removed needs/hardware This needs a piece of hardware that we are currently lacking labels Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/network server This is related to the Network Server compat/api This could affect API compatibility in progress We're working on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants