Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure gateway visibility in Packet Broker (Console) #4409

Closed
johanstokking opened this issue Jul 14, 2021 · 3 comments · Fixed by #5294
Closed

Configure gateway visibility in Packet Broker (Console) #4409

johanstokking opened this issue Jul 14, 2021 · 3 comments · Fixed by #5294
Assignees
Labels
c/console This is related to the Console ui/web This is related to a web interface
Milestone

Comments

@johanstokking
Copy link
Member

johanstokking commented Jul 14, 2021

Summary

Configure gateway visibility.

Why do we need this?

For administrators to configure the visibility of gateways in Packet Broker.

What is already there? What do you see now?

Configuration of routing policies.

Since #4667, there is CLI support to manage default gateway visibility. See API here: https://github.com/TheThingsNetwork/lorawan-stack/blob/feature/4409-pba-gateway-visibility/api/packetbrokeragent.proto#L405-L432

What is missing? What do you want to see?

Configuration of gateway visibilities. This works very similar to routing policies: there is a default, and there are specific visibility settings per Home Network.

The first phase only tracks default gateway visibility. We should keep this issue open for per-network settings.

In the Console, just like we have a "Default routing policy" tab, we need to have a "Default gateway visibility" tab, which includes checkboxes for the fields. This seems pretty straight-forward to me, but I might be mistaken.

How do you propose to implement this?

  1. Extend API; Pba service – Manage Packet Broker gateway visibility #4667
  2. Implement CLI supportManage Packet Broker gateway visibility #4667
  3. Implement Console support

How do you propose to test this?

Local test setup with Packet Broker staging or even production. Packet Broker already provides all the required functionality.

Can you do this yourself and submit a Pull Request?

Can do (1) and (2). Can review (3).

@johanstokking johanstokking added c/console This is related to the Console c/packet broker agent This is related to Packet Broker Agent ui/web This is related to a web interface labels Jul 14, 2021
@github-actions github-actions bot added the needs/triage We still need to triage this label Jul 14, 2021
@johanstokking johanstokking self-assigned this Jul 14, 2021
@johanstokking johanstokking added this to the 2021 Q3 milestone Jul 14, 2021
@NicolasMrad NicolasMrad removed the needs/triage We still need to triage this label Jul 16, 2021
@johanstokking johanstokking modified the milestones: 2021 Q3, v3.14.1 Jul 22, 2021
@johanstokking johanstokking modified the milestones: v3.14.1, v3.14.2 Aug 3, 2021
@johanstokking johanstokking modified the milestones: v3.14.2, v3.15.0 Aug 13, 2021
@NicolasMrad NicolasMrad modified the milestones: v3.15.0, 2021 Q3, v3.15.1, v3.15.2 Sep 14, 2021
@johanstokking johanstokking added the in progress We're working on it label Sep 24, 2021
@johanstokking johanstokking modified the milestones: v3.15.2, v3.15.1 Sep 24, 2021
@johanstokking johanstokking removed c/packet broker agent This is related to Packet Broker Agent in progress We're working on it labels Sep 24, 2021
@johanstokking johanstokking added the needs/triage We still need to triage this label Sep 24, 2021
@johanstokking johanstokking modified the milestones: v3.15.1, v3.15.2 Sep 24, 2021
@johanstokking
Copy link
Member Author

Updated the original comment and re-assigning to @kschiffer as Console is left for closing the first phase.

Also adding needs/triage so we can plan the exact milestone.

@NicolasMrad NicolasMrad removed the needs/triage We still need to triage this label Oct 5, 2021
@NicolasMrad NicolasMrad modified the milestones: v3.15.2, v3.16.0 Oct 5, 2021
@kschiffer kschiffer changed the title Configure gateway visibility Configure gateway visibility in Packet Broker (Console) Oct 26, 2021
@NicolasMrad NicolasMrad modified the milestones: v3.16.0, v3.17.0 Nov 9, 2021
@NicolasMrad NicolasMrad modified the milestones: v3.17.0, v3.17.2 Dec 20, 2021
@kschiffer kschiffer modified the milestones: v3.17.2, v3.18.0 Jan 13, 2022
@NicolasMrad NicolasMrad modified the milestones: v3.18.0, v3.18.1 Jan 31, 2022
@NicolasMrad NicolasMrad added the needs/ux This needs UX design / approval label Jan 31, 2022
@ryaplots ryaplots mentioned this issue Feb 24, 2022
5 tasks
@kschiffer kschiffer modified the milestones: v3.18.1, v3.18.2 Mar 2, 2022
@kschiffer kschiffer removed the needs/ux This needs UX design / approval label Mar 2, 2022
@kschiffer
Copy link
Member

kschiffer commented Mar 2, 2022

So per-network visibility settings are currently not implemented yet? If the plan is to include this short-term, we can already implement it as well in the Console.

Also, is it planned to inspect the gateway visibilities of other forwarder networks towards the own?

@johanstokking
Copy link
Member Author

Let's keep it simple for now and set default gateway visibility only.

The rest is possible too but not needed for now. If we start with the default config checkboxes we're good and we can keep that if we expand functionality.

@kschiffer kschiffer removed their assignment Mar 2, 2022
@ryaplots ryaplots added the in progress We're working on it label Mar 8, 2022
@ryaplots ryaplots removed the in progress We're working on it label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console This is related to the Console ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants