-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure gateway visibility in Packet Broker (Console) #4409
Comments
Updated the original comment and re-assigning to @kschiffer as Console is left for closing the first phase. Also adding |
So per-network visibility settings are currently not implemented yet? If the plan is to include this short-term, we can already implement it as well in the Console. Also, is it planned to inspect the gateway visibilities of other forwarder networks towards the own? |
Let's keep it simple for now and set default gateway visibility only. The rest is possible too but not needed for now. If we start with the default config checkboxes we're good and we can keep that if we expand functionality. |
Summary
Configure gateway visibility.
Why do we need this?
For administrators to configure the visibility of gateways in Packet Broker.
What is already there? What do you see now?
Configuration of routing policies.
Since #4667, there is CLI support to manage default gateway visibility. See API here: https://github.com/TheThingsNetwork/lorawan-stack/blob/feature/4409-pba-gateway-visibility/api/packetbrokeragent.proto#L405-L432
What is missing? What do you want to see?
Configuration of gateway visibilities. This works very similar to routing policies: there is a default, and there are specific visibility settings per Home Network.
The first phase only tracks default gateway visibility. We should keep this issue open for per-network settings.
In the Console, just like we have a "Default routing policy" tab, we need to have a "Default gateway visibility" tab, which includes checkboxes for the fields. This seems pretty straight-forward to me, but I might be mistaken.
How do you propose to implement this?
Extend API;– Manage Packet Broker gateway visibility #4667Pba
serviceImplement CLI support– Manage Packet Broker gateway visibility #4667How do you propose to test this?
Local test setup with Packet Broker staging or even production. Packet Broker already provides all the required functionality.
Can you do this yourself and submit a Pull Request?
Can do (1) and (2). Can review (3).The text was updated successfully, but these errors were encountered: