Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple "logged in" screen and branding to OAuth app #730

Closed
kschiffer opened this issue May 21, 2019 · 2 comments
Closed

Add simple "logged in" screen and branding to OAuth app #730

kschiffer opened this issue May 21, 2019 · 2 comments
Assignees
@kschiffer
Labels
c/shared This is shared between components needs/discussion We need to discuss this ui/web This is related to a web interface
Milestone
October 2019

Comments

@kschiffer
Copy link
Member

Summary

The oauth app is currently not properly branded. It needs to be branded dynamically based on the stack configuration.
Related: https://github.com/TheThingsIndustries/lorawan-stack/issues/1041

Why do we need this?

Basic functionality. Unbranded OAuth app leaves users unclear about the proper context.

What is already there? What do you see now?

Some OAuth app pages with no logos, brand titles or whatsoever.

What is missing? What do you want to see?

At least a configurable logo and title, together with header and/or footer.

Environment

OAuth provider in browser.

How do you propose to implement this?

Subject of discussion.

Can you do this yourself and submit a Pull Request?

Yes.
@kschiffer kschiffer added c/shared This is shared between components needs/discussion We need to discuss this labels May 21, 2019
@kschiffer kschiffer added this to the Backlog milestone May 21, 2019
@kschiffer kschiffer self-assigned this May 21, 2019
@johanstokking johanstokking modified the milestones: Backlog, Next Up Jul 9, 2019
@htdvisser htdvisser modified the milestones: Next Up, August 2019 Jul 23, 2019
@htdvisser htdvisser added the ui/web This is related to a web interface label Jul 23, 2019
@bafonins bafonins modified the milestones: August 2019, September 2019 Aug 27, 2019
@johanstokking johanstokking changed the title Add proper branding to oauth app Add proper branding to OAuth app Sep 11, 2019
@johanstokking johanstokking changed the title Add proper branding to OAuth app Add simple "logged in" screen and branding to OAuth app Sep 11, 2019
@johanstokking
Copy link
Member

@kschiffer please indicate what the discussion is and mention people to loop them in

@kschiffer kschiffer mentioned this issue Oct 4, 2019
Closed
@kschiffer
Copy link
Member Author

Closing in favor of #1422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kschiffer kschiffer

Labels
c/shared This is shared between components needs/discussion We need to discuss this ui/web This is related to a web interface
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
4 participants
@htdvisser @kschiffer @johanstokking @bafonins