Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to lyft/protoc-gen-validate #98

Closed
1 of 2 tasks
rvolosatovs opened this issue Feb 5, 2019 · 5 comments
Closed
1 of 2 tasks

Switch to lyft/protoc-gen-validate #98

rvolosatovs opened this issue Feb 5, 2019 · 5 comments
Assignees
Labels
compat/api This could affect API compatibility
Milestone

Comments

@rvolosatovs
Copy link
Contributor

rvolosatovs commented Feb 5, 2019

Summary:

Switch to https://github.com/lyft/protoc-gen-validate for validation instead of https://github.com/mwitkow/go-proto-validators

Why do we need this?

  1. Validators generated for languages besides Go
  2. Support for gogo extensions
  3. Way more features
  4. Proper tagged builds
  5. Backed by a known company

What is already there? What do you see now?

https://github.com/mwitkow/go-proto-validators

What is missing? What do you want to see?

https://github.com/lyft/protoc-gen-validate

How do you propose to implement this?

What can you do yourself and what do you need help with?

I'll take care of adding https://github.com/lyft/protoc-gen-validate to https://github.com/TheThingsIndustries/docker-protobuf.
Possibly reuse https://github.com/znly/docker-protobuf/pull/54
The protoc image contains the plugin since version 3.0.26

@htdvisser
Copy link
Contributor

I think we can remove the discussion label here. This is clearly something we need to do.

@htdvisser htdvisser removed the needs/discussion We need to discuss this label Feb 11, 2019
@htdvisser htdvisser changed the title Consider switching to lyft/protoc-gen-validate Switch to lyft/protoc-gen-validate Feb 11, 2019
@KrishnaIyer
Copy link
Member

This looks very promising but
a. It's still in the alpha stage.
b. has the following issues with go andgogoproto.
https://github.com/lyft/protoc-gen-validate/issues?q=is%3Aopen+is%3Aissue+label%3AGo

@johanstokking
Copy link
Member

@rvolosatovs looks like you did your contribution for this issue, are you still assigned?

@rvolosatovs rvolosatovs removed their assignment Feb 12, 2019
@rvolosatovs
Copy link
Contributor Author

Nope.

@htdvisser
Copy link
Contributor

We're closing this. Refer to TheThingsIndustries/protoc-gen-fieldmask#21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat/api This could affect API compatibility
Projects
None yet
Development

No branches or pull requests

4 participants