Syscall 10 (Exit) uses last code from Syscall 93 (Exit2)

[rladenson]

Syscall 10 (Exit) is supposed to always exit with code 0 (at least that's what it says in the documentation in RARS) however instead of this, if you have used Syscall 93 (Exit2, the one that lets you choose what code you exit with) since you opened the program, it uses the most recent exit code for that instead.

Repro:

1. Open Rars
2. Create a new file
3. Make the contents of that file

addi a7, zero, 93
addi a0, zero, 1
ecall

4. Assemble and run the file
5. Change the file contents to

addi a7, zero, 10
ecall

6. Assemble and run again

Expected: Should exit with code 0
Actual: Exits with code 1

[TheThirdOne]

Good catch. This should be a simple fix by setting exitCode to 0 in exit.

rars/src/rars/riscv/syscalls/SyscallExit.java

Lines 43 to 45 in 5e8dd10

	public void simulate(ProgramStatement statement) throws ExitingException {
	throw new ExitingException(); // empty exception list.
	}

rars/src/rars/riscv/syscalls/SyscallExit2.java

Lines 42 to 44 in 5e8dd10

	public void simulate(ProgramStatement statement) throws ExitingException {
	Globals.exitCode = RegisterFile.getValue("a0");
	throw new ExitingException(); // empty error list