Strip invalid tcp_connect fields in the web_connectivity test helper #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the ooni-backend side fix of: https://github.com/TheTorProject/ooni-probe/issues/727
bassosimone
reviewed
Jan 26, 2017
| collector: | ||
| httpo://ihiderha53f36lsd.onion: | ||
| collector-alternate: | ||
| - {address: 'https://a.collector.ooni.io:4441', type: https} |
There was a problem hiding this comment.
https://b.collector.ooni.io?
There was a problem hiding this comment.
Actually the canonical bouncer is currently using this address. Though anyways what is in here doesn't really matter for the purpose of the unittest.
There was a problem hiding this comment.
(I don't think it's relevant, however)
bassosimone
reviewed
Jan 26, 2017
| web-connectivity: 'httpo://7jne2rpg5lsaqs6b.onion'} | ||
| test-helper-alternate: | ||
| web-connectivity: | ||
| - {address: 'https://a.web-connectivity.th.ooni.io:4442', type: https} |
There was a problem hiding this comment.
IIRC https://b.web-connectivity.th.ooni.io?
There was a problem hiding this comment.
Same thing as above. The canonical bouncer is still advertising the old address. We should switch it though when we update to the version in here.
bassosimone
approved these changes
Jan 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the ooni-backend side fix of:
https://github.com/TheTorProject/ooni-probe/issues/727