doneNetTest is called while some measurements are still running

[hellais]

@hellais commented on Fri Oct 07 2016

This comes from the discussions inside of #612.

@darkk

The easy way to trigger that behaviour is to run a test against TARPIT. twisted has huge timeout to trigger ResponseNeverReceived in this case, something like ~1100 seconds. So the Measurement is not running as TaskWithTimeout tried to commit a suicide, but some offspring deferreds doing retries were kept alive. www.wallpapergate.com works like a TARPIT for me.

It looks like a bug, but that's not a blocker, I'm forking it to separate ticket to document it, but I'm unsure that we'll ever fix it due to upcomming MeasurementKit integration.

For context the function doneNetTest is writing Summary for ... with URLs and Report ID: https://github.com/TheTorProject/ooni-probe/blob/master/ooni/nettest.py#L515