Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When muted={true} the fullscreen volume control won't unmute #1192

Closed
kennym opened this issue Aug 21, 2018 · 9 comments
Closed

When muted={true} the fullscreen volume control won't unmute #1192

kennym opened this issue Aug 21, 2018 · 9 comments

Comments

@kennym
Copy link

kennym commented Aug 21, 2018

Current behavior

When I set muted={true} and try to unmute in the fullscreen player the sound won't unmute.

Expected behavior

I should hear sound after unmuting from the fullscreen controls.

Platform

Which player are you experiencing the problem on:

  • iOS
@lklepner
Copy link

#232 might be related

@lklepner
Copy link

Changing the volume setting to 0.0 rather than using muted={true} to achieve muting in advance of video playback has the same impact. The audio controls in the fullscreen view cannot be used to unmute the audio.

@guliash
Copy link

guliash commented Feb 3, 2019

@guoguozhang
Copy link

When muted={true} and controls={true} the muted btn not work in iOS ? Have nothing to do with fullscreen. Has no one solved the problem?

@snamstorm
Copy link

Also having this issue - when muted={true}, pressing unmute on the controls doesn't unmute

If muted={false} - sound works fine when pressing play on a video

@CHaNGeTe
Copy link
Contributor

CHaNGeTe commented Jul 6, 2019

Try this PR
#1654

@snamstorm
Copy link

@CHaNGeTe tested your code changes with my project and issue is fixed for me - hope #1654 can be merged soon. Thanks for fixing!

@CHaNGeTe CHaNGeTe mentioned this issue Jul 8, 2019
@CHaNGeTe
Copy link
Contributor

CHaNGeTe commented Jul 9, 2019

Check on 4.4.3

@CHaNGeTe CHaNGeTe closed this as completed Jul 9, 2019
@kennym
Copy link
Author

kennym commented Jul 15, 2019

Thank you! Happy to see this got fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants