Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Full-screen button not showing in android while using FlatGrid #3699

Open
Bindu009 opened this issue Apr 22, 2024 · 6 comments
Open

Comments

@Bindu009
Copy link

Version

v6 (Beta)

What platforms are you having the problem on?

Android

Architecture

Old architecture

What happened?

I can not see the fullscreen button while the video is playing on Android, and I am also using FlatGrid to show the video.

Environment Info

Library version: 5.2.1
Devices: Android version 13

Reproducible sample code

<FlatGrid
                        itemDimension={140}
                        data={imagePreview.filter(item => (["video/mp4"].includes(item.type)))}
                        style={styles.gridView}
                        spacing={10}
                        renderItem={({ item, rowIndex }) => (
                            <TouchableOpacity key={item.uniqueId} onLongPress={() => this.selectAction(item)} disabled={!displaySelectionButton} activeOpacity={0.9}>
                                <View style={[styles.itemContainer, { backgroundColor: "grey" }]}>
                                    <Video
                                        source={{ uri: (imageBasePath + item.path), cache: "web" }}
                                        style={[styles.listImage, {
                                            opacity: item.selected && displaySelectionButton ? 0.5 : 1,
                                            borderWidth: displaySelectionButton ? .1 : 0,
                                            borderColor: item.selected && displaySelectionButton ? "grey" : null,

                                        }]}
                                        controls={true}
                                        ref={(ref) => {
                                            this.player = ref
                                        }}
                                    />

                                    {item.selected && displaySelectionButton &&
                                        <Icon
                                            name="check-circle"
                                            size={25}
                                            color={"white"}
                                            style={{ position: 'absolute', top: 15, left: 10 }}
                                            family="fontawesome"
                                        />
                                    }
                                </View>
                            </TouchableOpacity>
                        )}
                    />

Image sample

android

Reproduction

repository link

Reproduction

I can not see the fullscreen button while the video is playing on Android, and I am also using FlatGrid to show the video.

@Bindu009 Bindu009 added the bug label Apr 22, 2024
@KrzysztofMoch
Copy link
Collaborator

There is no enough space for those controls so it seems like you will need to create custom controls to handle it

@Bindu009
Copy link
Author

Hi @KrzysztofMoch
Please find the screenshot below. Even though we have space, I am not getting the full-screen button.
Screenshot_1713882825

@KrzysztofMoch
Copy link
Collaborator

@freeboub I guess we need to update/fix controls layout?

@seyedmostafahasani
Copy link
Contributor

@KrzysztofMoch do you agree that we should change the position of the full-screen button? For instance, we could move it to the top-right. What do you think?

@KrzysztofMoch
Copy link
Collaborator

We cloud be this is not an issue - I think there is something wrong with (controls) layout - or maybe only for small views we should move it to top-right

@seyedmostafahasani
Copy link
Contributor

@KrzysztofMoch, I agree with you. We must change the position of the full-screen button to the top-right on a small view screen.
I will do it in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants