Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onVideoError and onVideoLoadStart native properties are unset #94

Closed
ethul opened this issue Sep 17, 2015 · 1 comment · Fixed by #103
Closed

onVideoError and onVideoLoadStart native properties are unset #94

ethul opened this issue Sep 17, 2015 · 1 comment · Fixed by #103
Labels
bug

Comments

@ethul
Copy link

ethul commented Sep 17, 2015

It looks like the onVideoError and onVideoLoadStart properties are not being set as nativeProps.

Should they be set to this._onError and this._onLoadStart?
@ghost
Copy link

ghost commented Oct 26, 2015

+1, onError does not get fired.

@isair isair mentioned this issue Nov 13, 2015
Merged
3 tasks
@isair isair added the bug label Nov 18, 2015
@cancan101 cancan101 mentioned this issue Nov 25, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@ethul @isair