Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear ansi-colored output #25

Closed
nadevko opened this issue May 1, 2022 · 1 comment
Closed

Clear ansi-colored output #25

nadevko opened this issue May 1, 2022 · 1 comment

Comments

@nadevko
Copy link

nadevko commented May 1, 2022

  1. When characters in the row have the same color, will be better print escape code only once: \e[38;5;20mw\e[38;5;20mm -> \e[38;5;20mwm
  2. Use only space as invisible character, when background and text have same color: \e[38;5;0m<char> -> \e[38;5;0m

Also, will be cool mixing --color and --color-bg. Maybe, in form --color=(fg|bg|both)

@TheZoraiz
Copy link
Owner

Looks like too much work for too little gain. There aren't any significant performance improvements, and it would just make the code a readability nightmare (more than it already is...). I also can't accept the flag alteration request as too many projects depending on ascii-image-converter will break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants