Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize Theano rfft with numpy rfftn #5771

Open
slefrancois opened this issue Mar 27, 2017 · 0 comments
Open

Harmonize Theano rfft with numpy rfftn #5771

slefrancois opened this issue Mar 27, 2017 · 0 comments

Comments

@slefrancois
Copy link
Collaborator

slefrancois commented Mar 27, 2017

Theano's fft functions correspond to numpy's fftn, for n-dimensionnal transform. This is confusing because numpy.fft.fft is the 1-D transform.

For both tensor.fft and and gpuarray.fft, we should rename the user functions (rfft > rfftn, irfft > irfftn) to fit numpy. The current user functions should be deprecated with a warning. The GPU replacement optimizers must be changed too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants