Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate using Nodatime for any date/time functionality #445

Open
SeanFarrow opened this issue Jul 26, 2021 · 1 comment
Open

Investigate using Nodatime for any date/time functionality #445

SeanFarrow opened this issue Jul 26, 2021 · 1 comment

Comments

@SeanFarrow
Copy link

Hi,

Having looked at this project (and really liking it), I noticed that the datetimeoffset type is used when representing the time passed since the Unix epoch.

As someone who is pretty fanatical about correct time representation and testing, I wondered whether you would consider switching to Nodatime. This would give you a type (Instant) that represents the time in UTC and therefore devoid of any timezone information as well as a clock representation that can be either mocked or have a fake representation injected that allows the manipulation of time during tests.

If this would be something you'd consider, I'm happy to put a proof of concept/PR together.

Thanks for the good work, it is really a time saver.

Sean.

@MarkusGeigerDev
Copy link

😞
#446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants