Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Cleanup: Campaign page #148

Open
space-dweeb opened this issue Mar 4, 2021 · 0 comments
Open

UI Cleanup: Campaign page #148

space-dweeb opened this issue Mar 4, 2021 · 0 comments
Assignees
Labels
help wanted Ready for someone to take
Projects

Comments

@space-dweeb
Copy link
Contributor

space-dweeb commented Mar 4, 2021

Please clean up the code and UI for the campaign page (front/src/pages/Campaign.vue) and its components (front/src/components/campaign).

The following should be true of the code:

  1. No custom CSS is used (size, color, font, etc). Style is added only through the layout system and Quasar classes listed here:
    https://quasar.dev/layout
    https://quasar.dev/style
  2. File names and component references should follow "hyphen-case" format, not using "_"s

The following should be true of the UI:

  1. All avatars are the same size (match Supporters)
  2. Spacing between UI elements is uniform, and edges align wherever possible
  3. Padding on "About Campaign" tab is increased to match "Campaign Wall" tab
  4. Tabs are renamed to "Wall" and "About"; About comes first
  5. Campaign description and comment content text is not faded. Stats (like # of likes, time posted, etc, can remain faded)
  6. Campaign stats (location, supporters, etc) match the mock (remove likes, shouldn't be in 3 column sections, etc):
    https://www.figma.com/proto/JnFz2HjnkulA1w7nvT1PaX/Then-We-Win-App?node-id=36%3A1281&scaling=min-zoom
  7. Comments better match mock (less space between text, smaller reply button, etc)
@space-dweeb space-dweeb created this issue from a note in App MVP (To-do) Mar 4, 2021
@space-dweeb space-dweeb added the help wanted Ready for someone to take label Mar 4, 2021
@mdashikar mdashikar self-assigned this Mar 10, 2021
@mdashikar mdashikar moved this from To-do to In progress in App MVP Mar 11, 2021
@mdashikar mdashikar moved this from In progress to PR made in App MVP Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Ready for someone to take
Projects
App MVP
PR made
Development

No branches or pull requests

2 participants