Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The question about initialization of 'rand_grid' in the ./auxiliary/model.py #2

Closed
tommaoer opened this issue Oct 30, 2019 · 2 comments
Closed

The question about initialization of 'rand_grid' in the ./auxiliary/model.py #2

tommaoer opened this issue Oct 30, 2019 · 2 comments
Assignees
@theodeprelle
Labels
bug Something isn't working

Comments

@tommaoer
Copy link

I have a question. In the file 'model.py', line 378,379, why the variable 'rand_grid' is initialized to uniform(0,1) before it is initialized to zero. What is the reason?
Thanks!
theodeprelle added a commit that referenced this issue Nov 4, 2019
@theodeprelle
adressing issue #2
d7ab414
@theodeprelle
Copy link
Owner

Hi,
Indeed there was a bug. You should zero the values of the last column starting from 2. I've updated the code today and it should work fine now. Thanks for letting me know this!

@tommaoer
Copy link
Author

tommaoer commented Nov 4, 2019

Thanks very much!

@tommaoer tommaoer closed this as completed Nov 4, 2019
@ThibaultGROUEIX ThibaultGROUEIX added the bug Something isn't working label Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theodeprelle theodeprelle

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ThibaultGROUEIX @tommaoer @theodeprelle