Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TextAreaLong to __all__ along with the other classes #101

Merged
merged 1 commit into from Oct 14, 2020

Conversation

amureki
Copy link
Contributor

@amureki amureki commented Oct 13, 2020

That should fix #89

@amureki amureki self-assigned this Oct 13, 2020
@amureki amureki changed the title Add TextAreaLong to __all__ along with the other classes Add TextAreaLong to __all__ along with the other classes Oct 13, 2020
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          26       26           
  Lines         870      870           
=======================================
  Hits          867      867           
  Misses          3        3           
Impacted Files Coverage Δ
heroku_connect/db/models/fields.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37347e9...f03fdf6. Read the comment docs.

@amureki amureki requested a review from Ashlett October 13, 2020 15:57
@amureki amureki assigned Ashlett and unassigned amureki Oct 13, 2020
Copy link
Member

@Ashlett Ashlett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ashlett
Copy link
Member

Ashlett commented Oct 13, 2020

hey, there's sth weird with the checks here 🤔 Travis build passed, but there is some 2nd pending travis check

@Ashlett Ashlett assigned amureki and unassigned Ashlett Oct 13, 2020
@amureki
Copy link
Contributor Author

amureki commented Oct 14, 2020

@Ashlett good that you noticed it!
I did found a solution to that here:
https://travis-ci.community/t/known-issue-travis-ci-reports-expected-waiting-for-status-to-be-reported-on-the-github-status-api-but-the-status-never-arrives/1154

After applying it disappeared, so we are good now!

@amureki amureki merged commit 3fefc60 into master Oct 14, 2020
@amureki amureki deleted the issues/89/textarealong_import branch October 14, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hc_models.TextAreaLong is missing from documentation
2 participants