Releases starting with 2.4.0 cause typescript errors

[Brian-Hofmann]

I just updated my DragSelect version from 2.3.1 to the latest (2.7.3 as of right now). When I ran my project, I now receive typescript errors relating to the SelectableSet and SelectedSet classes. I confirmed that this is an issue starting with 2.4.0. I am running this in an Angular app with typescript version 4.6.3. If there is anything on my side I am missing, please let me know. Thank you!

Screenshots:

[ssergdev]

+1

[ThibaultJanBeyer]

Hi there, thanks for pointing this out! Would you mind sharing an example code/project that reproduces this error?
Just FYI I’m also working on a typescript rewrite of the project but this will take some more time, would be good to get this fixed before.

[Ruslan207]

i investigated the issue. add() signature should be changed in SelectedSet.d.ts and SelectableSet.d.ts
it should be add(element: DSElement): this;

[ThibaultJanBeyer]

Ok that is simple enough! Will fix that quickly. I’ve been working on a complete typescript rewrite and it should come in 1-2 weeks also. But let me quickly fix this then :)

[ThibaultJanBeyer]

Fixed in 87254fd and version 2.7.4.
Please let me know if not.
Thanks @Ruslan207, feel free to just issue PRs next time :)

[Brian-Hofmann]

Thank you! I will try this and let you know

[Brian-Hofmann]

Works good! Thanks!