-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clicking on an empty space in the area will cause pixel offset #208
Comments
@Hweiya @ThibaultJanBeyer I don't know enough to say if that's the best way to verify scrollability, but I think we could implement the simple change shown in this diff. It performs the same operation, but restores the scrollTop property to it's original value before the DOM is updated. |
Hey everyone, thanks for using the tool!! @dbougan, feel free to issue a PR with your proposal and we get it merged as a workaround and add a @todo "find a better way to test scrollability". This gives us time to figure out if there is not a better way to test it. Unless you also feel like researching this immediately of course. |
Hey @ThibaultJanBeyer, I created a new Pull Request #210 with this change and a new test case to cover it |
Fixed in 3.0.4, thanks a lot @dbougan <3 |
I'm happy to help out @ThibaultJanBeyer, thanks for pulling it in! Also, I'm sorry to see about the test failure I caused. Apparently, during development, I was running yarn in a way that only ran tests related to my code changes. I see the correct way to run all tests now and will do that going forward. But thank you for sorting out the Settings tests! |
Describe the bug
Clicking on an empty space in the area will cause pixel offset
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I want it to stay still
Code Example
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: