Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error #212

Closed
Ruslan207 opened this issue Nov 21, 2023 · 5 comments · Fixed by #214
Closed

Build error #212

Ruslan207 opened this issue Nov 21, 2023 · 5 comments · Fixed by #214

Comments

@Ruslan207
Copy link

Ruslan207 commented Nov 21, 2023

Describe the bug
when i install and import DragSelect v3.03 or v3.0.4, it throws typing error
Error: node_modules/dragselect/dist/DragSelect.d.ts:767:40 - error TS2304: Cannot find name ‘E_1’.
767 publish: <T extends DSCallbackName<E_1>>(eventName: T | T[], data: DSPublishMappings[T]) => void;

I've checked DragSelect.d.ts in dist folder and E_1 is mentioned there only once

@kkkheladze
Copy link

Having the same problem... Settled down for v2.7.4

@ThibaultJanBeyer
Copy link
Owner

ThibaultJanBeyer commented Feb 19, 2024

Hi there @Ruslan207 & @kkkheladze thanks a lot for using the tool and reporting! I'm looking into this at the moment. Would you mind sharing how you are building it? Like what's your environment? And ideally a sandbox that reproduces the error? Because internally the dogfood project is building fine.

@ThibaultJanBeyer
Copy link
Owner

I tried with a nextjs app and it builds fine. However the line you mentioned seems weird indeed. I'll have a look on what generates that line. If you experience this issue but want to use v3 you can rename E_1 to E for now.

@ThibaultJanBeyer
Copy link
Owner

I think I got it, PR is out

@ThibaultJanBeyer
Copy link
Owner

ThibaultJanBeyer commented Feb 27, 2024

It should be fixed now in 3.0.5, please re-try and let me know :)

Still would be nice if you could share your set-up so that I can add a test so it doesn't happen again in the future, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants