Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer fixes (2) #204

Closed
gboudreau opened this issue Sep 3, 2010 · 4 comments
Closed

Installer fixes (2) #204

gboudreau opened this issue Sep 3, 2010 · 4 comments

Comments

@gboudreau
Copy link
Contributor

  1. Notice: Undefined index: db_type in C:\wamp\www\thinkup_lib\controller\class.InstallerController.php on line 195
  2. Pesky timezone warning. This is a Smarty thing. We can just set it as the system timezone for now, before Issue Improve/correct timezone configuration #196 is done.
    http://php.net/manual/en/function.date-default-timezone-get.php
    http://php.net/manual/en/function.date-default-timezone-set.php
  3. When the database connection fails, investigate whether or not the installer can give details about what went wrong--server name bad? username/password?, etc.
  4. Some systems can't use exec(), which is used by the installer to identify the user running HTTPd. When that happens, we should only show the create the file manually option. If exec fails, it probably means the user is on a shared host, and he won't be able to use root or sudo to chown anyway.
  5. MySQL port number is ignored.
  6. Super minor copy change: the heading "Requirements Check" on step 1 should be: "Check System Requirements" (more active).
  7. Edit the README.md to include instructions on how to run the crawler in the web interface. Remove all the command line instructions--folks can see those on the web page, customized to their setup.

Strikethrough points are fixed already.

@gboudreau
Copy link
Contributor Author

My branch where I'll fix some of those: http://github.com/gboudreau/ThinkUp/tree/204-installer_fixes

@gboudreau
Copy link
Contributor Author

Got the fix for point 4 committed; just need Enil (mailing list) to confirm what exec() returns on his system. Will amend my commit if the current empty(exec(...)) I'm doing isn't correct.

@gboudreau
Copy link
Contributor Author

Pull request created #217. Maybe we can continue to track new bugs there, so that commits and comments are grouped together?

@ginatrapani
Copy link
Member

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants