Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom luminance JSONs are not parsed #8

Closed
VioletRoses opened this issue Nov 7, 2023 · 3 comments
Closed

Custom luminance JSONs are not parsed #8

VioletRoses opened this issue Nov 7, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@VioletRoses
Copy link

VioletRoses commented Nov 7, 2023

Describe the bug
My Minecraft mod uses LambDynamicLights for certain items, and though I've successfully hooked into the RyoamicLights API for entities, the mod appears not to parse item luminance JSONs, even though the folder structure is setup the exact same as on Fabric.

To Reproduce
Steps to reproduce the behavior:

  1. Launch instance with Weird Equipment (1.0.4 or higher) and RyoamicLights
  2. Equip Netherite Torch Pickaxe
  3. Observe no lighting being emitted

Screenshots
Mod running with RyoamicLights:
Screenshot 2023-11-07 130135

Running with LambDynamicLights:
Screenshot 2023-11-07 130122

Desktop (please complete the following information):

  • OS: Windows
  • Minecraft 1.20.1
  • Fabric Loader version 0.14.24
  • Mods: Rubidium, RyoamicLights, WeirdEquipment
  • Version 0.1.5
@VioletRoses VioletRoses added the bug Something isn't working label Nov 7, 2023
@VioletRoses
Copy link
Author

FYI i've tried renaming the "dynamiclights" folder in assets to "ryoamiclights" thinking that could've been the issue and it just wasn't documented in the API.md but that did nothing.

@TexBlock
Copy link
Member

You seem to have misplaced Custom luminance JSON, it should be in assets\<modid>\dynamiclights\.

@TexBlock TexBlock self-assigned this Nov 15, 2023
@TexBlock
Copy link
Member

This is RyoamicLights' ResourceReloader issue, will fix in 0.1.6

@TexBlock TexBlock closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants