Simplify and refine where possible #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove docs and exports for `Transparent` type generic - remove `toTransparent` util - rename ~toOpaque~ --> `castToOpaque` - recommend unique symbols for stronger types
jossmac
commented
May 27, 2022
| @@ -35,35 +35,33 @@ type ThingThree = Opaque<string, 'ThingTwo'>; | |||
| // 🚨 Non-unique `Token` parameter | |||
| ``` | |||
|
|
|||
| You can, and should, use recursive types for your opaque types to make them stronger and hopefully easier to type. | |||
| While string literals are accepted tokens, we recommend [unique symbols](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-7.html#unique-symbol) for your opaque types to make them stronger. Each reference to a unique symbol implies a completely unique identity that’s tied to a given declaration. | |||
There was a problem hiding this comment.
Recommendation on unique symbol use with opaque types
emmatown
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opaques changes:
Transparenttype generic (still used internally)toTransparentutiltoOpaquetocastToOpaqueMisc. changes:
booleancondition againstassert()isDefined()