Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: npm:x@y doesn't work for tags #193

Closed
KATT opened this issue Jan 11, 2024 · 3 comments 路 Fixed by #194
Closed

Bug: npm:x@y doesn't work for tags #193

KATT opened this issue Jan 11, 2024 · 3 comments 路 Fixed by #194

Comments

@KATT
Copy link
Contributor

KATT commented Jan 11, 2024

Heya, super grateful for this lib, it keeps things tidy 馃Ч

In my case now, it seems to make things too tidy, where it doesn't allow me to use @tag

I added a dep in my monorepo for e.g. "@trpc/server": "npm:@trpc/server@next", (note it has a tag and not a version at the end). Manypkg does not like that.

鈽旓笍 error @examples/standalone-server has a dependency on @trpc/server@npm:@trpc/server@next but the version of @trpc/server in the repo is 10.45.0 which is not within range of the depended on version, please update the dependency version

See trpc/trpc#5315:

CleanShot 2024-01-11 at 21 34 01@2x

@Andarist
Copy link
Collaborator

The most surprising thing for me here is that you say that it doesn't error like this with npm@trpc/server@1.2.3 馃槄

Fixing this should be fairly easy here. Would you perhaps want to do it? 馃槈

@KATT
Copy link
Contributor Author

KATT commented Jan 12, 2024

Of course you're involved in this project, @Andarist, you're fucking everywhere 馃槀鉂わ笍

@Andarist
Copy link
Collaborator

The path from being a user to becoming a maintainer is surprisingly short at times 馃槄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants