Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible CPU consumption issue with FR24Feed and no ulimit set #126

Closed
MaxWinterstein opened this issue Jun 6, 2023 · 0 comments · Fixed by #129
Closed

Possible CPU consumption issue with FR24Feed and no ulimit set #126

MaxWinterstein opened this issue Jun 6, 2023 · 0 comments · Fixed by #129

Comments

@MaxWinterstein
Copy link
Contributor

MaxWinterstein commented Jun 6, 2023

After we tackled the OOM issues (see e.g. #107) users using HomeAssistant OS 10 also had issues with CPU usage from FR24Feed.

The root cause is the same as the OOM issue, the removal/change of ulimit.

I did a fix in my repo by setting a ulimit also for FR24Feed- see MaxWinterstein/homeassistant-addons#151 (comment) and MaxWinterstein/homeassistant-addons#160

I am kinda confused about two things:

  • Does this also happen for users of this repo? I can't believe it does not
  • There is a property ULIMIT_N that is a system-wide setting according to the README, but in fact, it is just used for the thttp service.

My proposal on that would be to

  • Change the ULIMIT_N to something like HTTP_ULIMIT_N and add a new FR24FEED_ULIMIT_N property. Maybe make the ulimit thing generic for all run files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant