New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Html textarea does not accept value property #25
Comments
so the correct attributes would be:
plus global attributes? |
|
Yes it is. Does this map https://github.com/Thomazella/react-known-props/blob/master/src/generated/reactHtmlElementsToPropsMap.js contain HTML attributes or react properties? |
both I think. Goal here was to have all props react recognizes |
Ok, I reported the issue as we use your Result of |
I think so, we've been using this lib with react. Are you saying that for your use case you'd rather only have valid HTML attributes? |
Yea, this is what we expected. Anyway, we still use your lib with a small workaround. If |
Maybe we should update docs at least, thoughts? or maybe rename the function, add jsdoc comments 🤔 |
I think the name of the library is enough. It's react-known-props. Can't be more descriptive. But if it causes confusion, emphasizing this in the readme is a good idea. |
About
Html
textarea
properties (source: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea),value
is not a valid one:autocapitalize
Note: This [autocapitalize] is a non-standard attribute supported by WebKit on iOS (therefore nearly all browsers running on iOS, including Safari, Firefox, and Chrome), which controls whether and how the text value should be automatically capitalized as it is entered/edited by the user. The non-deprecated values are available in iOS 5 and later
autocomplete
autofocus
cols
disabled
form
maxlength
minlength
name
placeholder
readonly
required
rows
spellcheck
wrap
textarea
also accepts global attributes: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes.Possible solution
The correct attributes need to be added here https://github.com/Thomazella/react-known-props/blob/90885fbbcdac6eb4b88f74e195f8a8b48fbc1e0f/src/generated/reactHtmlElementsToPropsMap.js#L309-L331
The text was updated successfully, but these errors were encountered: