Can @types/electron be removed as a devDependency?

[walkingriver]

I'm pulling ngx-electron into my project as a dependency, which has a dependency on @types/electron, which appears to have a dependency on electron. This causes my Angular app's node_modules to have a complete electron distribution in it, which it never uses. However, when I then use electron-builder, it dutifully pulls it in. According to this (https://www.npmjs.com/package/@types/electron), there is no reason to include @types/electron anymore. Should it be removed entirely?

[walkingriver]

For grins, I did try what I'm suggesting. I forked the repo and removed @types/electron from package.json entirely. Now it won't build, because the namespace Electron doesn't exist. I imagine there must be a way to do this without bringing in the entire electron package as an angular dependency. I just can't think of what that is.

[ThorstenHans]

@walkingriver electron provides it's own types since two weeks I think. They've deleted @types/electron as mentioned on npmjs.

I'm currently refactoring ngx-elecrton to work again correctly.

[walkingriver]

Let me know if there's anything I can do to assist.

[ThorstenHans]

thanks for the offer. I've just published 1.0.3 on npmjs perhaps can you try it in your scenario / build. I've tested and verified functionality with @angular/cli based samples.

@walkingriver

related to #10

[ThorstenHans]

@walkingriver thanks for the input I'm closing this due to the currently working 'workaround' 😄 and the upcoming release mentioned in #11