Expose Router.isClosed

[gf3]

i'm attempting to write a health check for a service that uses watermill and i'd like to be able to easily determine if the router is still up and running

Router exposes a channel at .Running(), and it's possible to infer if the router is closed with a little indirection:

running := false
go func() {
  r := router.Running()

  for {
    if _, open := <-r; open {
      running = true
    } else {
      running = false
      return
    }
  }
}()

however it would be much simpler if we could simply call router.IsClosed(). perhaps there is another solution i've missed?

[roblaszczak]

Hey @gf3, yes, it should be possible to easily add such a function.

It needs unit test to verify, but I think that writing the IsRunning function should like:

func (r Router) IsRunning() bool {
   select {
      case <- r.Running():
          return true
      default:
         return false
  }
}

running := false
go func() {
  r := router.Running()

  for {
    if _, open := <-r; open {
      running = true
    } else {
      running = false
      return
    }
  }
}()

But it's not really IsClosed(), because it can be not yet running. But for the health check you are probably interested with IsRunning :)

[roblaszczak]

If you or anybody else have 10 mins please feel free to add that function :)