This repository has been archived by the owner on Jan 8, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
Service should use Node address if not populated #7
Labels
Comments
@bencyoung thanks for the info! Sadly I don’t have time to implement this atm happy to accept a PR for this functionality. |
I'll see what I can do! |
I can't easy upload a PR from where I am, but this patch I think does what's needed
|
I will take a look when I get a chance! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When a health check in Consul returns, it can have a null Address. This is because services can be registered with an empty address. The docs at https://www.consul.io/api/agent/service.html say:
Address (string: "") - Specifies the address of the service. If not provided, the agent's address is used as the address for the service during DNS queries.
If a service doesn't have an address then Ocelot should use the node address instead
The text was updated successfully, but these errors were encountered: