Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#989 Added annotations to ignore outputcache and file config endpoints #1532

Closed
wants to merge 0 commits into from
Closed

#989 Added annotations to ignore outputcache and file config endpoints #1532

wants to merge 0 commits into from

Conversation

b-shep
Copy link

@b-shep b-shep commented Nov 2, 2021 •
edited by raman-m

Fixes #989

Added annotations to cause ApiExplorer to ignore outputcache and file configuration endpoints thus preventing them from registering with Swagger.

Proposed Changes

  • Add ApiExplorerSettings(IgnoreApi=true) to OutputCacheController and FileConfigurationController to prevent Swagger from registering and displaying them in public facing gateway documentation

@raman-m raman-m added invalid Not actually an issue waiting Waiting for answer to question or feedback from issue raiser labels May 16, 2023
@raman-m raman-m self-requested a review May 18, 2023 13:52
@raman-m raman-m requested a review from TomPallister May 18, 2023 13:59
@raman-m raman-m added accepted Bug or feature would be accepted as a PR or is being worked on in progress Someone is working on the issue. Could be someone on the team or off. and removed invalid Not actually an issue waiting Waiting for answer to question or feedback from issue raiser labels May 18, 2023
@raman-m raman-m removed the in progress Someone is working on the issue. Could be someone on the team or off. label Jun 3, 2023
@raman-m raman-m removed the accepted Bug or feature would be accepted as a PR or is being worked on label Aug 28, 2023
@raman-m raman-m removed the request for review from TomPallister August 28, 2023 17:13
@raman-m raman-m changed the title Added annotations to cause ApiExplorer to ignore outputcache and file… Added annotations to ignore outputcache and file config endpoints Aug 28, 2023
@raman-m raman-m added proposal Proposal for a new functionality in Ocelot needs feedback Issue is waiting on feedback before acceptance labels Aug 28, 2023
@raman-m raman-m mentioned this pull request Aug 28, 2023
Closed
@raman-m raman-m changed the title Added annotations to ignore outputcache and file config endpoints #989 Added annotations to ignore outputcache and file config endpoints Aug 28, 2023
@raman-m
Copy link
Member

raman-m commented Sep 2, 2023

@b-shep Hi Ben!
Thanks for your interest in Ocelot!

The feature branch has been rebased onto ThreeMammals:develop!
Welcome to code review!

@raman-m raman-m closed this Sep 2, 2023
@raman-m
Copy link
Member

raman-m commented Sep 2, 2023

@b-shep @b-shep-ascent
Sorry, the PR was closed automatically after updating your develop branch with the latest commits from the base branch.
This PR cannot be reopened because you used develop branch which is protected one.
Could you create new feature branch from develop and make new PR please?

@Marusyk @darcon77 @joaopgrassi
FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marusyk Marusyk Marusyk approved these changes

@raman-m raman-m raman-m approved these changes

Assignees

@b-shep b-shep

Labels
needs feedback Issue is waiting on feedback before acceptance proposal Proposal for a new functionality in Ocelot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide FileConfiguration and OutputCache controller from Swagger
3 participants
@b-shep @raman-m @Marusyk