Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for dates which are syntactically correct but invalid #94

Open
michaelwood opened this issue Sep 29, 2023 · 1 comment
Open
Labels
bug There is a fault with the existing software

Comments

@michaelwood
Copy link
Member

We have had a publisher publish "valid" data with an awardDate as 2022-02-29, this causes python's datetime.date.fromisoformat(date) to error with day is out of range for month (which is correct error).

This could be handled at the application (in this case the datastore) that consumes this data to ignore this and replace it with a default or it could be (I think more usefully) raised as validation error.

@robredpath
Copy link

ThreeSixtyGiving/standard#283 would allow us to resolve this in schema, I think - although it's described as "format", I believe the "date" format disallows impossible dates, such as 29th Feb in non-leap-years

@mariongalley mariongalley added the bug There is a fault with the existing software label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug There is a fault with the existing software
Projects
None yet
Development

No branches or pull requests

3 participants