Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java.util.spi.LocaleServiceProvider prevents threetenbp to be used on Google App Engine #22

Closed
clementdenis opened this issue Dec 3, 2014 · 2 comments

Comments

@clementdenis
Copy link

org.threeten.bp.format.DateTimeTextProvider and org.threeten.bp.format.DateTimeFormatStyleProvider both implement java.util.spi.LocaleServiceProvider, which is not in the Google App Engine JRE whitelist: https://cloud.google.com/appengine/docs/java/jrewhitelist

I'm not sure why this was implemented this way, but the corresponding class in java.time don't implement this interface.

Could the interface be removed and the method "public Locale[] getAvailableLocales()" added to each class to ensure backward compat and allow thretenbp to run on GAE?

@jodastephen
Copy link
Member

I am happy to see pull requests to enhance use on Android. I don't have an Android dev environment nor much spare time, so that it the only realistic way to achieve a change ;-)

@clementdenis
Copy link
Author

Thanks for your very fast answer, but I'm talking about Google App Engine here (the Google's PAAS).

I checked the DateTimeTextProvider in JDK8, the LocaleServiceProvider interface never made it when the code was imported into the JDK.

As threetenbp is a backport, why not remove this interface to make it more like JSR310?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants