Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid HTTP URI format in http.py #140

Closed
JonnoFTW opened this issue Oct 9, 2020 · 1 comment · Fixed by #148
Closed

Invalid HTTP URI format in http.py #140

JonnoFTW opened this issue Oct 9, 2020 · 1 comment · Fixed by #148
Labels
bug Something isn't working

Comments

@JonnoFTW
Copy link
Contributor

JonnoFTW commented Oct 9, 2020 •
edited

thriftpy2/thriftpy2/http.py

Line 63 in a8b7873

HTTP_URI = '{scheme}://{host}:{port}{path}'

It's missing the / between the port and the path and should be:

HTTP_URI = '{scheme}://{host}:{port}/{path}'

This only occurs if you leave out the / in your path variable.
@ethe ethe added the bug Something isn't working label Oct 9, 2020
@ethe
Copy link
Member

ethe commented Oct 9, 2020

Thank you for reporting, yes it is a bug.

@aisk aisk mentioned this issue Nov 12, 2020
Merged
@ethe ethe closed this as completed in #148 Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix HTTP_URI typo in http.py Thriftpy/thriftpy2
2 participants
@JonnoFTW @ethe